search

sa-gl / feedback

🎮 🐛 Issue reporting and tracking for SA:GL Launcher & Website
https://sagl.app
0 stars 0 forks source link

Deleting server is slow #14

Open mikecnr opened 3 years ago

mikecnr commented 3 years ago

When deleting a server from the list it takes a few seconds. Assuming it just refreshes the list every few seconds. Possible to force a refresh immediately? It makes you feel like your click didn't work.

tmfksoft commented 3 years ago

This is a bug. Annoyingly, in our code we do refresh the list instantly. Instead the 5 second query update refreshes the list the next time it fires. image

I want to commit to fixing this in 1.0.4 but we'll see what makes it into 1.0.4.

tmfksoft commented 3 years ago

This is still present, some of this is based off the fact the UI doesn't get updated straight away. Steps are as follows:

  1. User clicks delete
  2. UI Tells the app to delete the server
  3. App deletes the server
  4. App tells the UI the server list has been changed
  5. The UI requests the server list from the App
  6. The App responds with the server list
  7. The UI renders the server list.

It's quite a long winded process and can be shortened to

  1. User clicks delete
  2. UI removes server from internal state and tells the app
  3. UI renders updated server list and requests the latest server list

As a result this introduces the delay where the database is being updated and read from rather than the UI responding with the assumption the server was deleted, which is common in most apps.

The bug is still open and we plan to rectify the issue in a future update.