search

sa-lee / liminal

Multivariate Visualisations with Tours and Embeddings
https://sa-lee.github.io/liminal
Other
5 stars 0 forks source link

tourr version dependence #11

Closed uschiLaa closed 3 years ago

uschiLaa commented 3 years ago

The interface with tourr will need to be updated to work with version 0.5.7 (not yet on CRAN)

sa-lee commented 3 years ago

How do you mean? As in the package doesn't work on the dev version of the tourr?

uschiLaa commented 3 years ago

I initially had the dev version of tourr installed, this gave me an error (which might be a bug in tourr):

limn_tour(pdfsense, PC1:PC6, Type) Error in path(0) : object 'verbose' not found

after installing the stable tourr version from CRAN everything works ok

sa-lee commented 3 years ago

Has something changed internally for new_tour() in 0.5.7?

sa-lee commented 3 years ago

This is a bug in new_tour() in 0.5.7 https://github.com/ggobi/tourr/blob/26838bad2b4cd91f9b01f3ac5dff4c63acc3466c/R/tour.r#L54 It expects a boolean called verbose that isn't. passed in by default.

Want me to PR?

uschiLaa commented 3 years ago

Yes, there is a new "verbose" argument that turns on keeping track of information as the tour is running. It is initialised in "animate" or "save_history" as a global object, so if you call new_tour directly it is not defined. Would be good to check with Sherry, so PR or issue in the tourr repo

sa-lee commented 3 years ago

Ok I'll add that in now. I'm kind of concerned about the amount of <<- with the new verbose arg. Lots of modifying the external environment which seems unnecessary.

sa-lee commented 3 years ago

Ok this should work with current tour now