search

sa-mw-dach / manuela-dev

Manuela Demo Apps
Apache License 2.0
13 stars 96 forks source link

Edge anomaly detection component #11

Closed stefan-bergstein closed 4 years ago

stefan-bergstein commented 4 years ago
  1. 1st version of the component
  2. installation of open data hub
DanielFroehlich commented 4 years ago

question: why is the odh-instance in the iot-consumer component manifest? should that also be in the new "edge-anomaly-detection" component?

DanielFroehlich commented 4 years ago

next question: what is the rationale behind the component name "edge-anomaly-detctetion"? Currently, all components start with "iot-....", and we have a lot of flexibility where we actually deploy this component. I dont like the "edge" in the name, because we might deploy it nearedge, faredge, or even in the dc. suggest to name it "iot-anomaly-detection-ml"

DanielFroehlich commented 4 years ago

as per chat, my comments will be fixed by stefan, closing this one without merge.

stefan-bergstein commented 4 years ago

addressed comments and a few other issues

ortwinschneider commented 4 years ago

Looks good to me. Just one question: There is a seldon-deployment-crd.yaml in the components folder. Wondering if the CRD should be better placed in the namepsaces_andoperators.... folder? Normally operators introduce new CRs through CRDs (CRDs close to operator and CRs close to app components) What do you think?

stefan-bergstein commented 4 years ago

Re: Seldon CRD. Open Data Hub is suboptimal. It does not install all CRDs. The Seldon CRD is only needed for the Anomaly Detection. Therefore I put it there.

wrichter commented 4 years ago

The namespaces_and_operator Dir is there to instantiate operators in a separate step before installing CRs based on the operator CRD. OLM does instantiate CRDs asynchronously, therefore the CRDs are not instantaneously available (and the k8s API Server will reject CRs for them for a short while). If you bring your own CRD that shouldn’t matter