frontend uses hardcoded URLs to services

sa-mw-dach / opendj

Apply Open Source principles to the Dance Floor! MOVED TO https://github.com/opendj/opendj

https://github.com/opendj/opendj

GNU General Public License v3.0

6 stars 9 forks source link

frontend uses hardcoded URLs to services #35

Closed DanielFroehlich closed 5 years ago

DanielFroehlich commented 5 years ago

Thats not good, makes it impossible to move to different environments. Example: OpenDJ/frontend/app/src/app/home/home.page.ts: ... const playlistUrl = 'http://playlist-dfroehli-opendj dev.apps.ocp1.hailstorm5.coe.muc.redhat.com/api/v1/'; ...

DanielFroehlich commented 5 years ago

Hi Column! Could you please make this an ENV Variable so we can set it from outside? Thx Dan

col1985 commented 5 years ago

@DanielFroehlich yep no problem

DanielFroehlich commented 5 years ago

Moved to current project so that I can close "01 - Secure Hackathon Work"

DanielFroehlich commented 5 years ago

Will be fixed by new frontend impl by @ortwinschneider