sa-tre / satre-specification

Standard Architecture for Trusted Research Environments specification
https://satre-specification.readthedocs.io
Creative Commons Attribution 4.0 International
18 stars 8 forks source link

Use consistent path for downloadable satre.xlsx spreadsheet #295

Closed manics closed 11 months ago

manics commented 11 months ago

:white_check_mark: Checklist

:ballot_box_with_check: Maintainers' checklist

:arrow_heading_up: Summary

Currently we use the Sphinx :download: role to make the satre.xlsx spreadsheet available, but this results in a random hash being included in the published path. This is annoying since we can't link directly to the spreadsheet.

This PR is a workaround so that satre.xlsx is always in the base directory, without a prefix, so in future we can use https://satre-specification.readthedocs.io/en/stable/satre.xlsx instead of https://satre-specification.readthedocs.io/en/stable/_downloads/<random-hash-which-changes-every-release>/satre.xlsx

:closed_umbrella: Related issues

:raising_hand: Acknowledging contributors

manics commented 11 months ago

The linkcheck step is still failing.... without indicating what the error is 🙁. It runs fine locally.

manics commented 11 months ago

Another benefit of a consistent URL is we could automatically compare the last stable (tagged) satre.xlsx with the version from a PR, and use https://github.com/simonw/csv-diff to describe the differences that need to be made to an existing evaluation.