search

sa2blv / SVXportal

A web portal for svxlink reflector
http://svxportal.sm2ampr.net/
20 stars 13 forks source link

Errors in the code that may affect development #29

Closed f5vmr closed 1 year ago

f5vmr commented 1 year ago

I have spent a great deal of time viewing the project in learning about PHP, jscript and HTML. In using VSCode I discovered two problems that may have escaped the authors eye. In some pages, a variable 'i' was missing the '$' ahead of it to make it '$i' in the relevant loop structure. Because of the way VSCode works I cannot tell you in which files the error existed. However one error that I can confirm, I found in the index.html in the kml folder. A closing ')' brace was missing from the jscript. I think I found the correct place in which to add this brace, but it may affect the production of Version 2.6 if it is not corrected.

Understanding the personal difficulties of the author, I have made a complete correction of all the spelling errors in a repository on my own github/f5vmr.

A great project - looking forward to 2.6

sa2blv commented 1 year ago

file and line ?

sa2blv commented 1 year ago

file SVXportal/kml/index.php / the files kml is oboslite and not int use anymore.

sa2blv commented 1 year ago

variable 'i' and $i is mixe in the code due to mix between javascipt and php.

f5vmr commented 1 year ago

I have been using VSCode in several projects, increasing my back office skill in PHP. Because VSCode batch-corrects errors I didn’t note any line number.

Initial examination of 2.5 by VSCode reported several repeating issues - undeclared variable ‘i’ in a number of places where most of the loop shows variable '$i’.

The variable $i is in several files - get_statistics.php, index.php, log.php, request_notification.php, user_settings.php admin/log.php admin/settings.php admin get_statistics.php and possibly some other files.

The missing brace ')' is in xml/index.php but where it went I wasn’t sure. There were a couple of other errors reported in the same file, but this is probably due to the missing brace.

There are also a number of CSS errors reported by VSCode that empty rulesets - ' style=“” ' should not be used.

Hope that helps

Chris

On 1 Feb 2023, at 13:45, Peter @.***> wrote:

file and line ? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

f5vmr commented 1 year ago

All understood, Thanks for the clarification.

Chris

On 1 Feb 2023, at 13:49, Peter @.***> wrote:

variable 'i' and $i is mixe in the code due to mix between javascipt and php. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>

f5vmr commented 1 year ago

Closed