saade / filament-adjacency-list

A Filament package to manage adjacency lists (aka trees).
https://filamentphp.com/plugins/saade-adjacency-list
MIT License
74 stars 13 forks source link

add support for RTL #1

Closed atmonshi closed 1 year ago

atmonshi commented 1 year ago

added support for RTL direction. added Arabic translation. fix <x-blade-icon in resources/views/components/item.blade.php line 44

and thank you so much for this 🙏🏽

atmonshi commented 1 year ago

screenshot for rtl page:

Screenshot 2023-08-18 at 6 31 17 PM Screenshot 2023-08-18 at 6 19 13 PM
saade commented 1 year ago

Hi, thanks! What's the reason for using @svg instead of <x-icon?

atmonshi commented 1 year ago

Hi, thanks! What's the reason for using @svg instead of <x-icon?

it won't work in filament default installation, throw exception: (component not found)

since filament disables the blade components for the blade icons by default. \Filament\Http\Middleware\DisableBladeIconComponents

saade commented 1 year ago

LOL, didn't know that. Any reason for it to be working in my environment?

atmonshi commented 1 year ago

not sure :), did you remove 'DisableBladeIconComponents' from the middleware in AdminPanelProvider?

or you already published the config for blade icon and set it to true 'blade-icons.components.disabled'

atmonshi commented 1 year ago

ya definitely the config blade-icons.php

'disabled' => false,

saade commented 1 year ago

oh, I've published it to support a custom icon set in my current project. thanks for the information =)