search

saade / filament-fullcalendar

The Most Popular JavaScript Calendar as a Filament Widget
MIT License
291 stars 88 forks source link

Inconsistence between the code and the README.md #115

Closed chickgit closed 4 months ago

chickgit commented 1 year ago

in here you mentioned that to open url in new tab by providing 'shouldOpenUrlInNewTab' => true

but in this code https://github.com/saade/filament-fullcalendar/blob/90a3adab4ecd1ebd5f04903d4a1993aef9119716/resources/js/filament-fullcalendar.js#L51-L55 the 'shouldOpenUrlInNewTab' is inside extendedProps.

right now im using 'shouldOpenUrlInNewTab' inside extendedProps so that event can opened in new tab.

saade commented 4 months ago

Its intended, every extraneous property gets pushed to extendedPros.