search

saadeghi / daisyui

🌼 🌼 🌼 🌼 🌼  The most popular, free and open-source Tailwind CSS component library
https://daisyui.com
MIT License
33.18k stars 1.27k forks source link

bug: btn doesn't accept `--fallback` tokens as first option. #2975

Open icukovic opened 5 months ago

icukovic commented 5 months ago

What version of daisyUI are you using?

v4.10.1

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

https://play.tailwindcss.com/XuToYOqkWo

Describe your issue

While playing around with daisyUI I've noticed that the daisyUI Button is not taking --fallback-p CSS token as the the first var() option for background color, due to implementation with token called --btn-color and it always expects --falback-p or --p to be in oklch format

daisyUI src/component/styled/button.css as of today for browsers that support oklch generates:

image

while src/components/styled/badge.css for comparison always accepts --fallback tokens as first and they can be in any type value. image

github-actions[bot] commented 5 months ago

Thank you @icukovic for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

icukovic commented 5 months ago

Also I understand that this --btn-color was created to simplify button states recoloring with color-mix function.

khuezy commented 1 month ago

I also noticed this when trying to use daisyui custom themes in an email client, which doesn't support oklch