saadeghi / daisyui

🌼 🌼 🌼 🌼 🌼  The most popular, free and open-source Tailwind CSS component library
https://daisyui.com
MIT License
34.14k stars 1.3k forks source link

bug: Join, elements are not aligned since the last update #3118

Closed Resumane closed 1 month ago

Resumane commented 4 months ago

What version of daisyUI are you using?

4.12.10

Which browsers are you seeing the problem on?

Chrome

Reproduction URL

https://play.tailwindcss.com/GsxvhHLLKW

Describe your issue

The items in Join are not aligned since the last update, please fix.

github-actions[bot] commented 4 months ago

Thank you @Resumane for reporting issues. It helps daisyUI a lot πŸ’š
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

sergei-krylov commented 2 months ago

To add into that issue - it happens when both vertical and horizontal options specified, i.e. join-vertical lg:join-horizontal.

The issue is even visible in the docs, in "Responsive" example: https://daisyui.com/components/join/#responsive-its-vertical-on-small-screen-and-horizontal-on-large-screen, the first button is lower than others in horizontal mode.

gabrielCarraretto commented 1 month ago

It seems that the last bug fix is causing it.

4.12.10 (2024-06-26)

Bug Fixes

  • join spacing adapting to button border width (da94f2c), closes #3028

Downgrading to 4.12.9 fixes the problem

 yarn upgrade daisyui@4.12.9

or

npm i daisyui@4.12.9
saadeghi commented 1 month ago

Fixed in 4.12.11

Thanks @gabrielCarraretto for finding the cause of problem πŸ’š