saadeghi / daisyui

๐ŸŒผ ๐ŸŒผ ๐ŸŒผ ๐ŸŒผ ๐ŸŒผ โ€ƒThe most popular, free and open-source Tailwind CSS component library
https://daisyui.com
MIT License
34.18k stars 1.31k forks source link

bug: btn btn-xs btn-square isn't square because min-height remains fixed to 3em #3138

Closed cadolphs closed 4 months ago

cadolphs commented 4 months ago

What version of daisyUI are you using?

4.12.10

Which browsers are you seeing the problem on?

Chrome

Reproduction URL

https://play.tailwindcss.com/6vWlxyeC85

Describe your issue

Can't use the playground because that uses an older version apparently?

<button class="btn btn-xs btn-square">x</button>

for me generates a button of width 24px but height of 48px, because the base .btn class still sets min-height to 3 rem and it doesn't get overriden.

github-actions[bot] commented 4 months ago

Thank you @cadolphs for reporting issues. It helps daisyUI a lot ๐Ÿ’š
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

cadolphs commented 4 months ago

๐Ÿคฆ

I keep forgetting that even with automated page reloads, the django test server doesn't automatically reload the CSS. Everything works as intended now.

Thanks for the great tool!