search

saadeghi / daisyui

🌼 🌼 🌼 🌼 🌼  The most popular, free and open-source Tailwind CSS component library
https://daisyui.com
MIT License
34.14k stars 1.3k forks source link

bug: Textarea line height is too high, imo #3180

Closed alexandreL closed 3 months ago

alexandreL commented 3 months ago

What version of daisyUI are you using?

4.12.10

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

https://play.tailwindcss.com/WayqISZyMb

Describe your issue

In my opinion, the line height is too high inside a textarea. I investigated a little, and found that in unstyled/textarea.css, that the leading-loose which makes too much space between the lines of text, and should be removed.

image

I'll let you decide whether it's relevant or not. It may be a breaking change for some people.

github-actions[bot] commented 3 months ago

Thank you @alexandreL for reporting issues. It helps daisyUI a lot 💚
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

saadeghi commented 3 months ago

It's for better readability.
Every single component from daisyUI are opinionated and come with design decisions. Our goal is to provide the defaults which works for the majority and then for the small details like this, everyone can apply their own tweaks using utility classes. You can add leading-normal to decrease the line height:
https://play.tailwindcss.com/uHGVjEiQh2

Let me know if you have a question.