saadeghi / daisyui

๐ŸŒผ ๐ŸŒผ ๐ŸŒผ ๐ŸŒผ ๐ŸŒผ โ€ƒThe most popular, free and open-source Tailwind CSS component library
https://daisyui.com
MIT License
34.13k stars 1.3k forks source link

bug: btn btn-link btn-disabled looks like button but not link #3216

Open bogdan opened 2 months ago

bogdan commented 2 months ago

What version of daisyUI are you using?

No response

Which browsers are you seeing the problem on?

All browsers

Reproduction URL

https://play.tailwindcss.com/8cJA9JDvCP

Describe your issue

I believe that when btn btn-link btn-disabled are used together, the result should look like Link but not a button. While, link-disabled is not currently defined, I believe the fact that these 3 classes can be used together requires to define a style for disabled link. In practice the disabled link can be used like this:

<div class="tooltip " data-tip="Profile is not yet published" >
  <a href="#" class="link link-disabled">View Public Profile</a>
</div>
github-actions[bot] commented 2 months ago

Thank you @bogdan for reporting issues. It helps daisyUI a lot ๐Ÿ’š
I'll be working on issues one by one. I will help with this one as soon as a I find a solution.
In the meantime providing more details and reproduction links would be helpful.

saadeghi commented 2 months ago

How should it look like?

bogdan commented 1 month ago

I believe like so: https://play.tailwindcss.com/00Fv24VDxV

image

nilaygit-10721 commented 2 weeks ago

can you assign me this issue

saadeghi commented 2 weeks ago

Thanks @nilaygit-10721
All issues with v5 tag are already fixed in daisyUI 5 (alpha) or are in progress.
I can't change this style in daisyUI 4 because this visual change is a breaking change and it will effect all the existing apps who are relying on the previous behavior.

daisyUI 5 will be released soon after Tailwind CSS 4

tats-u commented 7 hours ago

So is btn-ghost: https://github.com/saadeghi/daisyui/issues/3285