saadparwaiz1 / cmp_luasnip

luasnip completion source for nvim-cmp
Apache License 2.0
687 stars 32 forks source link

Use new luasnip-functions for expansion. #29

Closed L3MON4D3 closed 2 years ago

L3MON4D3 commented 2 years ago

Hi, I'm updating the expand-process of luasnip to allow for more functionality, these are the changes required on cmp_luasnips side :) Requires the refactor_expand-branch to be merged into luasnip.

saadparwaiz1 commented 2 years ago

Perfect :) will merge once that branch has been merged!

L3MON4D3 commented 2 years ago

When do you have some time to merge? We should merge simultaneously because expansion will be a bit broken if only one of the patches is present.

saadparwaiz1 commented 2 years ago

@L3MON4D3 I'm free all day today. let me know what time works best for you?

L3MON4D3 commented 2 years ago

Right now? :D

saadparwaiz1 commented 2 years ago

sounds good to me

L3MON4D3 commented 2 years ago

Merged!

L3MON4D3 commented 2 years ago

Clean👌👌

saadparwaiz1 commented 2 years ago

Merged here as well

L3MON4D3 commented 2 years ago

Very nice, that should keep conflicts to a minimum👍