search

saadparwaiz1 / cmp_luasnip

luasnip completion source for nvim-cmp
Apache License 2.0
712 stars 32 forks source link

Choice Node Integration #43

Open p0da opened 2 years ago

p0da commented 2 years ago

I would like to revive this issue and ask if you could add native choice node integration into this cmp source. While it certainly possible to create an alternative popup menu, having choice nodes integrated will streamline workflows (unified settings and styles). Thanks for considering.

saadparwaiz1 commented 2 years ago

what are you roughly expecting this to look like?

p0da commented 2 years ago

Whenever the choice node is jumped to, all the possible choices are displayed in cmp (potentially excluding the currently selected one?) and the user can confirm their selection immediately causing it to expand. It would essentially be the same as this just integrated into cmp instead.

saadparwaiz1 commented 2 years ago

I'm not really sure if integrating with cmp is possible as the sources just provide completion candidates and how to resolve them. A hacky way would be instead of passing snippets we pass in the choice node candidates when a choice node is active but that'd still leave the issue of completion candidate from other sources such as lsp/buffer polluting the completion menu.

@L3MON4D3 any thoughts on this?

p0da commented 2 years ago

I believe it possible to specify source priorities such that if one source returns completions none of the others are queried which should solve the pollution issue. Can't really speak to the rest of the problem however.

L3MON4D3 commented 2 years ago

In case you're not aware @p0da, luasnip already has integration with vim.ui.select for changing choices.

I'm not really sure if integrating with cmp is possible as the sources just provide completion candidates and how to resolve them.

I think it should be doable, take a look at this piece of code from the ui.select-integration, something similar could be done in the execute-function of a source.

cmp_luasnip could provide a second source for the choices only, then the priority for it could be modified without affecting the snippets.

saadparwaiz1 commented 2 years ago

I think it should be doable, take a look at this piece of code from the ui.select-integration, something similar could be done in the execute-function of a source.

I can definitely try this out. Will try to create a PR in a few days once I have some time 😄

L3MON4D3 commented 2 years ago

Nice, looking forward to it👍

saadparwaiz1 commented 2 years ago

@L3MON4D3 @p0da do you guys want to try out #45?