Closed saadparwaiz1 closed 4 months ago
Oh nice, that was fast :D
I think I'll add some api-functions for getting/setting choices to Luasnip, if anything changes internally we can prevent incompatibilities.
But it might be best to not use them right away in this patch, but do a follow-up when they were available in Luasnip for a while, that should prevent issues like those from the switch to add_snippets
.
I added get_current_choices
and set_choice
to require("luasnip")
.
On second thought, it probably won't hurt to use these in a new source, putting some small warning to update luasnip before using it somewhere should be enough
yeah sure sounds good. once @p0da can try it out I'll update it
Sorry for the delay, the extra source works quite well (may want to toss a mention in the readme about it). One quick question, is there any way to activate the source automatically (and prompt the user with the relevant choices) when jumping to a choice node as that would be a nice additional improvement.
If it's possible to trigger cmp from lua, you could use LuaSnips events
@L3MON4D3 have updated the code base to use the new api. let me know if it looks ok and I'll merge
A bit busy with work hopefully will pick this up in the coming weekend :)
Will this be merged in the near future?
Hi there, yes :) hopefully. Just been busy with my new job so haven't had the time to do some final things on this
Ok all good. Hope all is going well with all of that
Looking forward to this
+1 looking forward to this!
I even switchted to the branch to try it out .. I wish I had more lua skills to help
Hi everyone. Sorry for the delays on dev stuff! Been on a vacation plus just general busy with life. I'll be back next week and hope to finish this feature soon :)
any updates on this?
43