search

saadpasta / developerFolio

🚀 Software Developer Portfolio Template that helps you showcase your work and skills as a software developer. (This is currently not being actively maintained)
https://developerfolio.js.org/
GNU General Public License v3.0
5.5k stars 2.84k forks source link

Audit Improvement #195

Open aashutoshrathi opened 4 years ago

aashutoshrathi commented 4 years ago

Summary

We have served images in next-gen-format, but there are widgets which are serving JPG and also tons of performance, best practices, and accessibility fixes that needed to be made

Motivation

image

Full Report: Here

PS: For images by Twitter the links look like https://pbs.twimg.com/media/Ea53nYhUwAEUiEx?format=jpg&name=small if we could somehow intercept the request and change format to webp, it servers webp. For eg here: https://pbs.twimg.com/media/Ea53nYhUwAEUiEx?format=webp&name=small

naveen521kk commented 4 years ago

I just see that it is not possible until we actual get tweets and embed each one. I just checked that it uses Twitter's js lib which doesn't support it. Maybe just checking it is better.

aashutoshrathi commented 4 years ago

@naveen521kk I think even if leave these images, there are tons of other stuff to be done.

naveen521kk commented 4 years ago

If you can maybe list like below one.

This would be helpful to know what to be done.

kartikcho commented 4 years ago

This was discussed before too, check #82 for more context.

warengonzaga commented 4 years ago

hi @kartikcho how about creating a new issue for Performance Update? I love to work on it... I have skills in optimization.

kartikcho commented 4 years ago

Hi again, I would suggest waiting for this because our PR backlog has built up a bit. The plan is to get all the new features in and then stabilize the codebase a bit after with tweaks and bug fixes here and there. I think this issue resolved at that time would be optimal. Hope you'd still be interested then to help in optimizations!

warengonzaga commented 4 years ago

@kartikcho yes... I'll be using this for my Github page... and I want my github page load fast as possible and SEO friendly. Just assign it to me once the task is ready. Also, if you don't mind me asking I'm a core developer of animate.css and it is good to have some animation in developerFolio?

kartikcho commented 4 years ago

Ah, that's great to hear! I hope you like all the new stuff we are adding into this soon.

I like your suggestion and I've been working on adding a bit of interactivity in the experience too. My work on #260 will add animated illustrations and we are already using react-reveal for on scroll effects. If you could propose anything that could make things more interesting or a new interactive component design, I'm up for ideas!