search

saadpasta / react-blog-github

🔥 React + Github Issues 👉 Your Personal Blog
https://saadpasta.github.io/react-blog-github/#/
MIT License
784 stars 131 forks source link

I want to close the GitHub react card #16

Open mbaralle opened 4 years ago

mbaralle commented 4 years ago

How to reproduce

  1. Open an article
  2. Go to the bottom and move the mouse over the reaction emojis image
  3. Click on the blue smiley on the right to open the GitHub react card

Expected

Able to close the card

Actual

No way to close the card

Hint

jvnm-dev commented 4 years ago

Hi, actually you can close it by clicking on the blue smiley again.

... when a touch event is triggered outside of the react card ...

Indeed, this could improve the UX

saadpasta commented 4 years ago

@mbaralle you could close the popup by clicking the emoji reaction but you can improve the UX by closing the popup when user clicked outside the popup