search

saadpasta / react-blog-github

🔥 React + Github Issues 👉 Your Personal Blog
https://saadpasta.github.io/react-blog-github/#/
MIT License
787 stars 131 forks source link

Comments section #51

Closed xzebra closed 4 years ago

xzebra commented 4 years ago

As a temporary addition, I implemented the comments section. I haven't come up with a great solution to posting comments in an elegant way, as a Markdown editor would be required.

I included another Markdown element to display the comments. This made me reuse the HyperLink and CodeBlock overrides for the Markdown component so I made an include for those. In addition, the Commentcomponent reuses the AuthorDetails, AuthorAvatar... components, you could create new ones if desired.

To end, I changed a few styles to make the comments look OK and set position: static in PostReaction as now you can't use bottom as reference (I'm sure this could've been done better).

image

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with Vercel (learn more). To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/saadpasta/react-blog-github/g2ehcma6m ✅ Preview: https://react-blog-github-git-fork-xzebra-comments-section.saadpasta.vercel.app

saadpasta commented 4 years ago

@xzebra Look's awesome. I'll have a look

xzebra commented 4 years ago

Sure! I will work on it

saadpasta commented 4 years ago

@allcontributors please add @xzebra for code and idea

allcontributors[bot] commented 4 years ago

@saadpasta

We had trouble processing your request. Please try again later.

saadpasta commented 4 years ago

@allcontributors please add @xzebra for code

allcontributors[bot] commented 4 years ago

@saadpasta

I've put up a pull request to add @xzebra! :tada:

allcontributors[bot] commented 4 years ago

@saadpasta

I've updated the pull request to add @xzebra! :tada: