Not Compatible with Latest Atom (git diff changes)

saadq / bliss-ui

Ultra minimalist theme optimized for usage with base16-ocean.

https://atom.io/themes/bliss-ui

MIT License

17 stars 3 forks source link

Not Compatible with Latest Atom (git diff changes) #6

Closed framerate closed 5 years ago

framerate commented 5 years ago

Is this UI abandoned?

I took a stab at fixing it but I'm not a theme coder so I couldn't seem to make it look right!

More info here: https://github.com/atom/github/issues/1911

Just wondering if this is ever going to be updated or if I should take it over. Thanks!

saadq commented 5 years ago

No, it isn't abandoned although I haven't done much for it lately. I'll look into this and fix it soon!

framerate commented 5 years ago

Awesome!! It's not a hard fix I don't think. The info seemed like mostly new class names but apparently they had never seen someone customize the diff stuff as much as you did. :)

Make sure to check what they said on the arpk repo and let me know if I can help on the code side!

On Tue, Mar 5, 2019, 2:24 PM Saad Quadri notifications@github.com wrote:

No, it isn't abandoned although I haven't done much for it lately. I'll look into this and fix it soon!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/saadq/bliss-ui/issues/6#issuecomment-469882658, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEiM_odu1lvD05EwGgpXXeOfCwP2qtQks5vTu6CgaJpZM4bfnBk .

saadq commented 5 years ago

Great, should be able to push a fix by today then. I'll keep you posted here

saadq commented 5 years ago

This should be fixed in the latest version of bliss-syntax. It seems as though I have most of the git diff styling there. Please try upgrading bliss-syntax and let me know what you think.

No selection:

Added selection:

Deleted selection:

Hunk selection:

If anything still feels off, feel free to reopen this issue.

framerate commented 5 years ago

You're my hero dude. I'll check it out tomorrow!

On Tue, Mar 5, 2019, 9:18 PM Saad Quadri notifications@github.com wrote:

Closed #6 https://github.com/saadq/bliss-ui/issues/6.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/saadq/bliss-ui/issues/6#event-2183080315, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEiM5aO-1XNJlSK1xmEoGvDTHf-ejJVks5vT0-SgaJpZM4bfnBk .

framerate commented 5 years ago

I know it's a syntax thing but I wanted to keep the convo here. Not sure if you saw this with the latest deploy:

(1 deprecation)

saadq commented 5 years ago

Thanks for reporting, I'll look into it once I get home

saadq commented 5 years ago

Should be fixed as of v0.3.6. Thanks again @framerate! Also feel free to just open new issues in either repo as it makes it a bit easier to track stuff.

framerate commented 5 years ago

Will do! looks good! Thanks @saadq You're a badass!