fix put dev package in dev dependencies

saadq / lynt

✨ A zero config JavaScript linter with support for Typescript, Flow, and React.

MIT License

384 stars 6 forks source link

fix put dev package in dev dependencies #32

Closed danielpza closed 9 months ago

danielpza commented 5 years ago

These dependencies are not needed in runtime:

@types/cosmiconfig
@types/eslint
@types/execa
@types/meow
@types/node
@types/strip-ansi
@types/text-table
babel-eslint

I could have missed some, and I'm not sure about babel-eslint

saadq commented 5 years ago

babel-eslint actually needs to be included as a dependency to get the ESLint side of Lynt to work properly.

The rest looks good to me... but I actually think there might have been a reason I put the types in dependencies instead of devDependencies. Possibly so that users had type info if they were using Lynt programatically? I'm not sure if that's actually true though I'll look into that and get back to you ASAP.

danielpza commented 9 months ago

closing to keep my pending PRs list clean