search

saadq / node-latex

🧾 A utility for running LaTeX subprocesses in Node.
MIT License
58 stars 22 forks source link

listening to stdout and stderr with dummy function #9

Closed urshofer closed 6 years ago

urshofer commented 6 years ago

Otherwise, child processes can stall if they produce a lot of output in the buffers. At some point the internal buffer is filling up and the built-in backpressure mechanism causes the process to stop accepting output from the child.

saadq commented 6 years ago

Thanks for the fix, looks good! Can you just update your fork to have the latest stuff from master? It seems like the git diff is showing previous changes that have already been pushed to this repo with the options.args stuff.

urshofer commented 6 years ago

Hi

Thanks. I closed the PR, merged your master and opened it once again...

Best Urs

Am 09.11.2017 um 05:22 schrieb Saad Quadri notifications@github.com:

Thanks for the fix, looks good! Can you just update your fork to have the latest stuff from master? It seems like the git diff is showing previous changes that have already been pushed to this repo with the options.args stuff.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/saadq/node-latex/pull/9#issuecomment-343043459, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHI8E1OpLmReww3HK1EgFQQNPaCQ4XMks5s0n3xgaJpZM4QW-X4.

saadq commented 6 years ago

Oh, just as an fyi – if you push commits to your fork, your PR will automatically get updated with the latest changes. As you can see from the Files Changed tab here, this PR would have been fine as it now only contains the relevant changes.