saadq / resumake.io

📝 A website for automatically generating elegant LaTeX resumes.
https://resumake.io
MIT License
3.27k stars 444 forks source link

PDF fails to load when emojis are used #148

Open willjad opened 4 years ago

willjad commented 4 years ago

Describe the bug Resumake fails to load PDF when an emoji is entered in one of the resume fields.

To Reproduce Steps to reproduce the behavior:

  1. Open resumake
  2. Enter an emoji 😊 into one of the fields. On windows 10 this is easily done by Windows key + . (period), which opens a little menu to insert emojis.
  3. Click make.
  4. See error "Failed to load PDF file".

Expected behavior PDF loads, or resumake tells me not to put emojis on my resume.

Screenshots image

Desktop (please complete the following information):

saadq commented 4 years ago

Not too sure if LaTeX supports emojis, will look into it. Otherwise I'll probably just add some kind of clientside error message when people put in invalid characters.

Though as a side note I don't really recommend putting emojis in resumes :p

some reviewers may consider it unprofessional

willjad commented 4 years ago

https://tex.stackexchange.com/questions/3695/smileys-in-latex seems to suggest that it's possible if you have a font that supports it. From Jurassic Park, "your scientists were so preoccupied with whether or not they could, they didn't stop to think if they should." I agree that including emojis on a resume would be ill-advised.

kajeagentspi commented 3 years ago

The same error occurs when a Japanese Character has been inputted.

arpit0891 commented 2 years ago

We can create an exception point... If any invalid char is added then the character or the section is skipped