saadq / resumake.io

📝 A website for automatically generating elegant LaTeX resumes.
https://resumake.io
MIT License
3.26k stars 445 forks source link

Resume should be remade automatically on template switch #95

Open g-berthiaume opened 5 years ago

g-berthiaume commented 5 years ago

Describe the bug When using the import json functionality it is impossible to choose a template. No matter what template options you select, the template will stay to default (template 1).

To Reproduce Steps to reproduce the behaviour:

  1. Go on https://resumake.io/
  2. Click on import json button
  3. Select the json file in your computer
  4. Click on template x

Expected behaviour The resume will only appear in the template 1 format.

Screenshots image

Desktop (please complete the following information):

Additional context I have tried to empty cache and do a hard reload on the site, but it didn't work.

The jsonresume is a very promising idea and I would like to use it with your wonderful tool. Thanks.

saadq commented 5 years ago

Just to check, are you clicking the Make button after you switch the template? The resume generation doesn't happen until you click that button.

If that was the issue, then I think it might make resume generation occur on template switch as it might not be too intuitive right now.

g-berthiaume commented 5 years ago

You're right. When I clicked the make button, the template was correctly selected. My bad.

saadq commented 5 years ago

I'm going to leave this issue open as I think it currently is not intuitive. I think switching templates should automatically trigger resume generation, so will fix that soon.

g-berthiaume commented 5 years ago

Excellent. Thanks for your work.