search

saadtazi / firefox-profile-js

Firefox Profile creation using nodejs and CLI
MIT License
60 stars 30 forks source link

fix: remove deprecated jetpack-id dependency #119

Closed rpl closed 3 years ago

rpl commented 3 years ago

This PR contains the minimal amount of changes needed to remove the deprecated jetpack-id npm package from the npm dependencies.

This doesn't rip-off yet the support for the legacy extension manifest files, it does mainly replace the jetpack-id dependency by including the two small methods that are currently used by the firefox-profile package (deferring further cleanups to separate followups, which could remove the conversion of the manifest.name into a generated id along with rewriting some of the existing test cases).

Fixes #118

saadtazi commented 3 years ago

Thanks @rpl for handling this! Sorry for the delay.

saadtazi commented 3 years ago

@rpl: I just released firefox-profile@4.1.0

rpl commented 3 years ago

Thanks @rpl for handling this! Sorry for the delay.

don't worry at all, it took me longer to come back to the issue and open the PR :-)

@rpl: I just released firefox-profile@4.1.0

@saadtazi thanks you so much! :heart: