Fix `rm` on non-empty dir

saadtazi / firefox-profile-js

Firefox Profile creation using nodejs and CLI

MIT License

60 stars 30 forks source link

Fix `rm` on non-empty dir #126

Closed Gusted closed 3 years ago

Gusted commented 3 years ago

This fixes a issue I've been running into, whereby the tmp/firefox-xxxx wasn't empty(polluted with some tracing data?) and firefox-profile will error about not able to remove the directory due to it wasn't empty.

saadtazi commented 3 years ago

Thanks for opening a PR.

I think it is safe, we _cleanOnExit() only if the destinationDir option is provided which means we are only cleaning tmp dir...

saadtazi commented 3 years ago

👋 I just published firefox-profile@4.2.1.