Construction of volatile versions of sources was broken.
Only the volatile Source was being used, and consequently BDV movie recording etc didn't work properly.
There is still a TODO left in the code about fixing the CacheHints (which determine how blocks are enqueued).
However, to address that, I would wait for https://github.com/imglib/imglib2-cache/issues/18. Then it should be easily fixed by replacing the current code with the commented bit. For now, the CacheHints are set up as before, which is ok, but not ideal.
The unnecessary class N5VolatileSource has been removed, as well as the N5Source.asVolatile() methods which created N5VolatileSource. So, this PR technically breaks API, but I doubt that this was used anywhere...
bogovicj
commented
1 year ago
Construction of volatile versions of sources was broken. Only the volatile Source was being used, and consequently BDV movie recording etc didn't work properly.
There is still a TODO left in the code about fixing the
CacheHints(which determine how blocks are enqueued). However, to address that, I would wait for https://github.com/imglib/imglib2-cache/issues/18. Then it should be easily fixed by replacing the current code with the commented bit. For now, theCacheHintsare set up as before, which is ok, but not ideal.The unnecessary class
N5VolatileSourcehas been removed, as well as theN5Source.asVolatile()methods which createdN5VolatileSource. So, this PR technically breaks API, but I doubt that this was used anywhere...