Can't delete 3D ROIs(labels)

saalfeldlab / paintera

GNU General Public License v2.0

94 stars 17 forks source link

Can't delete 3D ROIs(labels) #347

Open wangyuhan01 opened 4 years ago

wangyuhan01 commented 4 years ago

I am trying to proof-read some segmentation labels and want to delete some 3D ROI(labels) completely. But it seems that I can't do 3d flood-fill with background labels any more and can only delete frame-by-frame. Any idea how I could get this to work? Many thanks!

hanslovsky commented 4 years ago

At the moment, unfortunately not. We made disable selection of background a few weeks or months ago. There are two possible solutions that are not mutually exlusive:

Make background selectable again
- but do not render in 3D
Add key shortcut for background flood fill (and possible for erase)

cc @igorpisarev @axtimwalde

axtimwalde commented 4 years ago

I think the real problem is that background (0) selection triggers rendering of a 3D mesh of the background which we do not want. How about background selection being ok but 3D rendering never including background? I.e. add a check to mesh generation: if selected id == background: don't; else do;?

axtimwalde commented 4 years ago

@wangyuhan01 as a temporary workaround, use a new id, make a note that this should be considered background and then 3D fill with that. Once the issue is fixed, you can merge that with background.

hanslovsky commented 4 years ago

I added that requirement to the initial comment. We could do the same thing for all invalid ids. That way, "erasing" from canvas would not need a special key and could also be used for flood-fill.

vzinche commented 4 years ago

I am also facing the same issue. Any functionality to flood fill with background or simply delete the label completely would be highly appreciated!

igorpisarev commented 4 years ago

Lattice lightsheet users have been asking about possibility to delete labels too. I was thinking how to implement this better and thought that we could add the following shortcuts, which I find a bit clearer than selecting the background label and using it for flood-filling:

delete the currently selected label entirely, for example, Ctrl+D, possibly with a confirmation dialog
2D flood-fill with background to erase the clicked 2D section of an object, for example, D+left click or F+right click
3D flood-fill with background to erase the clicked object, for example, Shift+D+left click or Shift+F+right click

hanslovsky commented 4 years ago

I like that @igorpisarev