Closed hanslovsky closed 4 years ago
This will be ready to merge after some usage testing.
@hanslovsky Just tested and everything worked well for me too. Should be good to go? Looks like after it's merged we would also need to remove Paintera2 from entry point configuration in https://github.com/saalfeldlab/paintera-cmd
Thanks for testing @igorpisarev I just rebased on top of master and force pushed. I will talk to @cpatrickc before merging because he had reported an issue when committing a canvas.
Update: Yes, we would need to remove the Paintera2 entry point from paintera-cmd.
@cpatrickc Can you check if this PR still throws an exception when you commit a canvas? I rebased this PR on top of master, i.e. all commits in master are also contained in this PR branch:
git switch remove-obsolete-interfaces-and-classes-rebased
# if you already have the branch in your local repository, you will probably have to force pull because I rebased:
git pull --force
# you should see version 0.23.4-SNAPSHOT in the installation
mvn clean install
# Confirm the correct version (should be 0.23.4-SNAPSHOT-b79c0d559a6cb6aff3eda0cd27963a5aaa2f2380):
jgo -U org.janelia.saalfeldlab:paintera:0.23.4-SNAPSHOT+org.slf4j:slf4j-simple:1.7.2 --version
# Run without --version flag but with path to your project directory instead
jgo org.janelia.saalfeldlab:paintera:0.23.4-SNAPSHOT+org.slf4j:slf4j-simple:1.7.2
Let me know if you still have issues with committing the canvas.
Thanks
Phil
@cpatrickc reported that the canvas issue does not persist anymore. I will go ahead and merge.
Same as #380 but rebased on master. Replaces #380
This PR is a draft to
HasHighlightingStreamConverter
HasIdService
HasLockedSegments
HasMaskForLabel
HasMeshCache
HasMeshes
HasSelectedIds
HasFloodFillState
HasFragmentSegmentAssignments
HasAxisOrder
Paintera
and helper classes for UIAxisOrder
Paintera2
->Paintera
src/main/kotlin
In the course of this clean-up, all handlers should be modified such that they use a specific source and do not request the current source from the viewer. The latter was necessary because all event handling and UI elements were managed by the viewer but with moving this responsibility into the individual sources, we can get rid of these hard-to-understand lines of code that query the viewer for the current source and check for many different interfaces.
This is a draft PR and it will probably take a while to update everything.
Fixes #379 and beyond