igorpisarev
commented
4 years ago I've been working on this, and I currently have two versions of the fix: https://github.com/saalfeldlab/paintera/tree/optimize-orthoslice-textures https://github.com/saalfeldlab/paintera/tree/optimize-orthoslice-textures-background-thread
The difference is that in the first branch the texture updates are performed on FX thread which is easier and seems to perform well enough, and in the second branch the texture updates are offloaded to a background thread. These texture updates include:
- keeping the source image up-to-date (during painting only the affected areas are rendered, so they are copied into the source image to keep it consistent)
- copying the source image into self-illumination and diffuse images while also adjusting the alpha channel and brightness with respect to the current settings
The version with the background thread is supposed to perform a little better, but there's also additional overhead due to synchronization. There is also a second image buffer for the self-illumination and diffuse maps: if the currently displayed texture images are modified on a background thread, some strange visual bugs occur and eventually JavaFX starts throwing errors. To solve this I use two buffers and swap them (while one of them is displayed, another is modified by the background thread, then they are swapped).
I will do a bit more benchmarking and debugging to see which version performs better and will then merge and release.
In the recent releases 0.23.x painting and 2D navigation became very slow. For some reason the 2D navigation works fine for several sources (raw+labels), but when the label source is set to invisible so that only raw data is displayed, it becomes very slow.
The call stack suggests that the FX thread spends a lot of time in this function: https://github.com/saalfeldlab/paintera/blob/master/src/main/java/org/janelia/saalfeldlab/paintera/viewer3d/OrthoSliceFX.java#L195-L215