saalfeldlab / paintera

GNU General Public License v2.0
95 stars 17 forks source link

Sources not completely loading all high resolution data #480

Closed cmhulbert closed 1 year ago

cmhulbert commented 1 year ago

reported by @axtimwalde provided image and comment: image

note the lack of full resolution in parts of the screen, I can drag it around and then they eventually fill, or other parts are reduced resolution, looks like some sort of double buffereing stops one step early?

It seems like the updates to the screen are not triggering until a movement occurs. Desired behavior is that Paintera should continue to load higher resolution data if available, and update the screen accordingly when higher resolution data is available .

Steps to reproduce:

  1. Open new Paintera project
  2. Load s3://janelia-cosem-datasets/jrc_hela-3/jrc_hela-3.n5
  3. Select /em/fibsem-uint16
  4. Observe that data doesn't load until moving the image
    • Additionally, if zooming in significantly, similar results to the above image can be seen,
cmhulbert commented 1 year ago

Thanks for finding this! I have a fix. In this commit (f56af481d402e0caa43beb7bb42c8ebd39e4cdb1) I updated the VolatileHierarchyProjector to use the newest version from BDV (we still copy it internally to Paintera, but the underlying code was updated). During this, I had missed some handling of how it reports whether there are any remaining invalid pixels.

It's updated in the following commit 3493cea5

axtimwalde commented 1 year ago

Lovely! Thanks!