search

saasbook / hw-acceptance-unit-test-cycle

5 stars 1.88k forks source link

add instructions to cp rottenpotatoes/ to hw5/ #19

Closed bill-auger closed 8 years ago

bill-auger commented 8 years ago

this assignment used to have all files in the root of the archive but this time the grader expects everything to within a hw5/ subdir

the instructions do suggest this but the directory in question is named 'rottenpotatoes' not 'hw5' so running the zip command in the instructions fails with "no such file hw5/everything"

this is not an ideal fix but an emergency patch - either the grader should be expecting the files in the root of the archive as before or expecting a 'rottenpotatoes' dir but not 'hw5' - especially as the assignment order tends to change

tansaku commented 8 years ago

I'm aware of this issue. Wouldn't it be better to reword the zip instructions to refer to the existing rp directory?

bill-auger commented 8 years ago

yes that would be better but currently the grader wants everything inside the archive in a directory named 'hw5' - this was only to satisfy the grader for now

tansaku commented 8 years ago

Really, it won't work if the directory name is changed?

tansaku commented 8 years ago

Have you double checked that something zipped according to new instructions worked?

bill-auger commented 8 years ago

ok apparently the grader accepts it regardless of the directory name - as long as there is an inner directory - so this PR should solve the issue without touching the grader