saasbook / hw-acceptance-unit-test-cycle

5 stars 1.88k forks source link

issues with coverage #27

Closed tansaku closed 8 years ago

tansaku commented 8 years ago

@nbartowski said:

I lost 20 pts because my controller coverage was too low (88.89%; I think you required 90%). When I looked at my coverage, the only lines not included were a few in the index method, which I didn't write (i.e. I downloaded the class version of the homework from github). I was under the impression from the directions that we didn't need to write tests for the index method, and I didn't as this assignment ended up taking significantly more time than the previous four and I couldn't afford anymore time. So my suggestion I guess is either: lower the percentage coverage required for the controller in future offerings or include the index method in the list of additional methods to write unit tests for in the instructions. Also, it looked like you either got all 20 pts or none at all. Maybe there could be a formula for how many pts one gets, as I wrote unit tests for create, update, destroy, and the new method to find movies with the same director. I'm not worried about my score, so no need to do anything now, this is just feedback

tansaku commented 8 years ago

great feedback @nbartowski - I've added the index method there as a quick fix - although I'd like to review this as part of a bigger review of this assignment