Bump Rails version or Rotten Potatoes

[natesholland]

Hey Armando! I'm hoping to use Rotten Potatoes for training our intern class here at Spiceworks. We're a rails shop so this is perfect for getting our interns up to speed quickly without overwhelming them on legacy code immediately. I bumped the Rails version to the latest 4.2.

Would you be interesting in added some tests to this project or is that something you ask the students to do so it wouldn't make sense to put in this example? I took 169 in Spring of 2014 (I think?) so I don't remember the specifics of the homeworks so if you don't want me to publish tests please let me know. If you want them I'd be happy to write up some basic rspec examples for review since we will likely need them for our intern training.

[armandofox]

we love it when people contribute to this stuff! i'll take a look at your PR.

what did you have in mind for tests?

if you wanted to be a real hero and help your interns.... i'm looking for hands-on help crafting a SERIOUS rspec assignment as well as a semi-serious AJAX assignment. ("AJAXpotatoes", which is rottenpotatoes with ajax enhancments and jasmine tests)

if you want to help me develop those, you'll get a shout out in the book (it's being revved now) if you're willing to open source those assignments so students in our courses can use them. if you're in SF i'd be happy to bash heads about this in person (tho the interwebs say you're in austin).... let me know either way.

speaking of the book, if you think your interns would find it useful, we'd love to offer it at a discount or something if you wanted to recommend it to them - we could set it up with an offer code so you wouldn't have to do a bulk purchase unless you specifically wanted to....

i'm at a conference in europe but lmk about the above and let's do this thing!

Armando Fox Professor, Computer Science Division Faculty Advisor, UC Berkeley MOOCLab fox .at. cs .dot. berkeley .dot. edu 581 Soda Hall MC#1776, Berkeley, CA 94720-1776 +1.510.642.6820 / http://www.cs.berkeley.edu/~fox

TAKE MY CLASS FOR FREE VIA edX: http://saas-class.org
LIKE IT ON FACEBOOK: http://facebook.com/saas-class TRY MY BOOK (NOT FREE): http://www.saasbook.info (goes with the course)

On Apr 25, 2016, at 11:41 AM, Nate Holland notifications@github.com wrote:

Hey Armando! I'm hoping to use Rotten Potatoes for training our intern class here at Spiceworks. We're a rails shop so this is perfect for getting our interns up to speed quickly without overwhelming them on legacy code immediately. I bumped the Rails version to the latest 4.2.

Would you be interesting in added some tests to this project or is that something you ask the students to do so it wouldn't make sense to put in this example? I took 169 in Spring of 2014 (I think?) so I don't remember the specifics of the homeworks so if you don't want me to publish tests please let me know. If you want them I'd be happy to write up some basic rspec examples for review since we will likely need them for our intern training.

You can view, comment on, or merge this pull request online at:

https://github.com/saasbook/rottenpotatoes-rails-intro/pull/8

Commit Summary

Bump Rails version or Rotten Potatoes File Changes

M Gemfile (6) M Gemfile.lock (68) Patch Links:

https://github.com/saasbook/rottenpotatoes-rails-intro/pull/8.patch https://github.com/saasbook/rottenpotatoes-rails-intro/pull/8.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

[natesholland]

Thanks for reviewing it!

As for tests on this project I was thinking about adding some basic controller tests (potentially view as well but I'm less confident in my view testing skills). I'm in charge of developing and teaching a crash course in Ruby on Rails for our interns so I am planning on using this app as a demo/hands-on tool and I thought it would be a more complete/honest/accurate demo if we had a few specs around it. I will probably be adding these today or tomorrow so if you would like I can send a PR upstream with my added tests.

I am also probably going to be building our intern training seminar on testing so I'd be very interested in developing some sort of assignment, example, or tooling around that! I am in Austin and I don't travel to the bay area with any regularity so I can't meet in person but I would be happy to exchange emails or hop on a google hang out or skype call to brainstorm some testing and rspec learning material.

I know almost nothing about AJAX since I'm a backend dev by day so that would probably end up a bit like the blind leading the blind.

Let me run the book idea by our Learning & Development Manager and see what he thinks since he's in charge of the full intern training program.

I've also been working on a very basic intro to web concepts (http verbs, html, paths, cookies, request params) and I built a pretty basic learning tool that we are going to use with our interns. If you would like to see it I have open sourced it here under the MIT license: https://github.com/natesholland/web_101 You are welcome to use or modify it for your coursework if you want.

You can email me at natesholland .at. gmail .dot. com if you would like to discuss any details further.

[armandofox]

cool, i'll take a look!

yoj might be interested in an app that does this and goes a bit farther. it didn't exist when you took the class:

https://github.com/saasbook/hw-sinatra-saas-hangperson

there's a bunch of other public repos in saasbook as well that contain other heavily-scaffolded assignments but this one is particularly close to web_101. i'll certainly point my students at it.

Armando Fox Professor, Computer Science Division Faculty Advisor, UC Berkeley MOOCLab fox .at. cs .dot. berkeley .dot. edu 581 Soda Hall MC#1776, Berkeley, CA 94720-1776 +1.510.642.6820 / http://www.cs.berkeley.edu/~fox

TAKE MY CLASS FOR FREE VIA edX: http://saas-class.org
LIKE IT ON FACEBOOK: http://facebook.com/saas-class TRY MY BOOK (NOT FREE): http://www.saasbook.info (goes with the course)

On Apr 26, 2016, at 5:34 AM, Nate Holland notifications@github.com wrote:

Thanks for reviewing it!

As for tests on this project I was thinking about adding some basic controller tests (potentially view as well but I'm less confident in my view testing skills). I'm in charge of developing and teaching a crash course in Ruby on Rails for our interns so I am planning on using this app as a demo/hands-on tool and I thought it would be a more complete/honest/accurate demo if we had a few specs around it. I will probably be adding these today or tomorrow so if you would like I can send a PR upstream with my added tests.

I am also probably going to be building our intern training seminar on testing so I'd be very interested in developing some sort of assignment, example, or tooling around that! I am in Austin and I don't travel to the bay area with any regularity so I can't meet in person but I would be happy to exchange emails or hop on a google hang out or skype call to brainstorm some testing and rspec learning material.

I know almost nothing about AJAX since I'm a backend dev by day so that would probably end up a bit like the blind leading the blind.

Let me run the book idea by our Learning & Development Manager and see what he thinks since he's in charge of the full intern training program.

I've also been working on a very basic intro to web concepts (http verbs, html, paths, cookies, request params) and I built a pretty basic learning tool that we are going to use with our interns. If you would like to see it I have open sourced it here under the MIT license: https://github.com/natesholland/web_101 You are welcome to use or modify it for your coursework if you want.

You can email me at natesholland .at. gmail .dot. com if you would like to discuss any details further.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub

[tansaku]

@natesholland thanks for this - I think we bumped the Rails version separately, so the main additions in this PR are replacing HAML with ERB.

Now personally I'm a big fan of ERB and think that it's probably easier for most students to work with ERB than HAML when they're trying to comprehend all the other things they need to work on this assignment. However HAML is more succinct than ERB and @armandofox is a big fan and really prefers his students work with HAML, so it would be kind of a big change to this assignment that we'd need to get consensus on before merging ...

[armandofox]

I'm closing this because this single PR both updates versions of Ruby/Rails and also changes all the Haml templates to html.erb, which doesn't fit with the course goals or the lecture material. @natesholland I do appreciate the effort and you're certainly free to fork the repo and make a modified version that uses erb for your in-house course, but PRs to these repos affect a great many instructors who are using these materials so unless the PRs are bug fixes or addressing specific pedagogical issues/roadblocks for students we try to be conservative in making big changes.