search

sabaatworld / HyperionScreenCap

Screen capture program for Hyperion ambilight. Updated to support DirectX 11, multiple displays and multiple Hyperion servers.
MIT License
118 stars 18 forks source link

Add Flatbuffers support #30

Closed janpfischer closed 3 years ago

janpfischer commented 5 years ago

Hi,

since Hyperion.ng is moved to flatbuffer and removed protobuff can we look into implementing flatbuffer in hyperionscreencap?

If I connect hyperionscreencap to flatbuffer no data is transferred.

I could help with testing if you want.

sabaatworld commented 5 years ago

Does the app not work at all with new Hyperion versions?

jonty-comp commented 5 years ago

After some trouble I believe the dev who replaced Protobuf with Flatbuf ended up reimplementing both, but recommends Flatbuf for future implementations.

On Fri, 21 Jun 2019, 06:48 Sabaat Ahmad, notifications@github.com wrote:

Does the app not work at all with new Hyperion versions?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sabaatworld/HyperionScreenCap/issues/30?email_source=notifications&email_token=AAI3CUYSXXQHS7Q5X3T5RBDP3RTTBA5CNFSM4GWMKJD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYHPZYQ#issuecomment-504298722, or mute the thread https://github.com/notifications/unsubscribe-auth/AAI3CUY6UI47VD6H5A7RW3TP3RTTBANCNFSM4GWMKJDQ .

janpfischer commented 5 years ago

We implemented both to give apps like this the chance to update or maybe implement both. Protobuf will be deleted again. Then this software will not work with all future hyperion.ng versions.

jay9ee commented 4 years ago

Protobuf doesn't seem to be working anymore on new hyperion.ng versions.

janpfischer commented 4 years ago

On Alpha.4 it is working for me.

jay9ee commented 4 years ago

For me Hyperion screen capture says it connected successfully but it doesn't show up on Hyperion ng source selection, neither on a raspberry nor on my PC running Hyperion ng on Linux Mint, I tried binary and self compiled versions on both.

janpfischer commented 4 years ago

Which priority do you have selected in hyperscreencap?

jay9ee commented 4 years ago

Well color me dumb. I tried with different values before but it didn't want to work maybe I tried values too high actually. Now with priority 160 it works. On the standard 10 it doesn't work tho.

janpfischer commented 4 years ago

Yeah would be good to change the standard here since Hyperion.ng only allows priorities between 100-254. all other are reserved internally

IATkachenko commented 3 years ago

Is any news about Flatbuffers for ScreenCap?

sabaatworld commented 3 years ago

I'm not well versed with either but I think we need to start with getting the flat buffer object definitions. Can someone point them out?

sabaatworld commented 3 years ago

I've implemented flat buffer support in the latest commit but I don't have Hyperion set up. Can anybody test it?

sabaatworld commented 3 years ago

Nevermind, I tested it out as well and its working. Will include in next release.

sabaatworld commented 3 years ago

New release is out now. Please open another issue if flat buffer does not work.