search

sabareeshkkanan / robinhood

Unofficial Robinhood Open API Specification
35 stars 10 forks source link

Amazing work #9

Closed bdowling closed 5 years ago

bdowling commented 6 years ago

@sabareeshkkanan -- this is some amazing work that you've pulled together. I have been planning to do this as well, but you beat me to it, so owe you some thanks!

I have been working to make some improvements to this and plan on using it in a python implementation.

As my implementation case has some differences, trying to think how to separate those concerns from the general API schema improvements so that I can share these back with you.

You'll see that in my branch I renamed operationIDs for example to better work in python, as well as the Multiple<> since the angle brackets aren't valid class names.

Some of the other things I've added though include adding the tags methods, using ENUM types where appropriate, historical quotes methods, etc.

fwiw, I pushed my changes up here.. https://github.com/bdowling/robinhood-1/tree/local

Let me know your thoughts on how you'd like to see the PRs, etc, and again, Thank you for your efforts on this!

sabareeshkkanan commented 6 years ago

@bdowling i created a PR to see the changes. As the json and yaml are generated i will take a look at how to change actual code. Thanks for the feedback

sabareeshkkanan commented 5 years ago

please see my comment in pr