search

sabbelasichon / typo3-rector

Rector for TYPO3
MIT License
228 stars 63 forks source link

BUG: RenameClassMapAliasRector does not rename anymore, but add classname #2388

Closed helsner closed 3 years ago

helsner commented 3 years ago

The PageRepository is not renamed/replaced, but the new namespace is added to my file while the old one is kept.

This happens with the newly integrated rector/rector setup (so no direkt typo3-rector dependency)

Bildschirmfoto 2021-05-20 um 08 30 43

sabbelasichon commented 3 years ago

Thanks. Could you add the whole file here. So i can add it to my tests and see what´s wrong. Maybe it has something to do with the prefixed version, maybe not.

helsner commented 3 years ago

https://github.com/DFAU/cache-warmer/blob/6db34860fbb454f0ab5bebe088c0ae32fa32a140/Classes/Utility/FrontendSimulatorUtility.php

This is before my commit that changed the segment. (which then is the same file on master, i did by hand)

helsner commented 3 years ago

a second similar bug is on both the new rector/rector but also the prefixed dev-main occurring

The Response class does not get replaced. viewhelper.txt Bildschirmfoto 2021-05-20 um 14 15 36

sabbelasichon commented 3 years ago

This is a bug in rector itself i am on it. https://github.com/rectorphp/rector/issues/6441