[BUGFIX] Consider existing coalesce for _GET and _POST

sabbelasichon / typo3-rector

Rector for TYPO3

MIT License

215 stars 60 forks source link

[BUGFIX] Consider existing coalesce for _GET and _POST #4227

Closed simonschaufi closed 2 months ago

simonschaufi commented 2 months ago

Resolves: #4223

simonschaufi commented 2 months ago

@sabbelasichon I'm not happy with the globalsToPsr7ServerRequestFactory at the moment because it does a lot more now than it should. How would you refactor this class to handle the global variables as well?

Somehow I also want to consider #4224 but this is much more complex as I need to know which return type is expected and I don't know how to "know" the context in which the method is in.