sabby3861 / idoubs

Automatically exported from code.google.com/p/idoubs
0 stars 0 forks source link

Display Name not working #89

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Configure a display name in the idoubs Settings
2. Make a outgoing call
3.

What is the expected output? What do you see instead?
The called part should display the "display name" of idoubs, but it only 
displays number not name.
From the wireshark we can see that not matter in Register or Invite message, 
idoubs never carry the display name in either From or Contact fields.

What version of the product or source code revision are you using? On what
operating system?
Xcode 4.2, iOS 5.0, Nov. 1 idoubs source code.

Please provide any additional information below.
The display name seems stored in the IDENTITY_DISPLAY_NAME field, but never 
being used.
Furthermore, the impu uri seems can carry display name in its display_name 
field, but if we configure impu as something like 
"idoubs"<sip:1000@idoubs.com>, it could not be parsed.
And, if impu having display_name, the tsip_uri_clone function could not copy it 
into new_uri, because the 
tsip_uri_parse function seems could not parse uri with quote enabled, or said 
the if the quote in tsip_uri_serialize is tsk_true, the tsip_uri_parse will 
fail.

Hoping by fixing these issues, idoubs can include the "display name" in the 
From message.

Original issue reported on code.google.com by jimapple...@gmail.com on 10 Dec 2011 at 2:39

GoogleCodeExporter commented 9 years ago
Here is the ABNF for From header: 
http://www.tech-invite.com/Ti-abnf-sip-hf.html#From
Don't confuse "name-addr" and "addr-spec" (a.k.a sip uri). A Sip URI 
(http://www.tech-invite.com/Ti-abnf-sip.html#sipuri) NEVER takes a display 
name. In iOSNgnStack we use "callAudioVideo()" and "callAudio()" C++ function 
to make calls. Both functions accept to kind of parameters: a string or a 
SipUri object. By default we always use the override taking a string 
(http://code.google.com/p/idoubs/source/browse/branches/2.0/common-ngn-stack/sip
/NgnAVSession.mm#224). The string is an "addr-spec" and  ' "idoubs" 
<sip:1000@idoubs.com> ' is not valid. What you want is the second override 
which take a SipUri object which will be serialized as a "name-addr".

SipUri uri("sip:1000@idoubs.com", "idoubs");
_mSession->callAudio(&uri);

Original comment by boss...@yahoo.fr on 13 Dec 2011 at 4:38

GoogleCodeExporter commented 9 years ago
Additional info: The code above will set a display name to the remote party Uri 
(To:).
As you may expect, you can do the same for the From: header by using a SipUri 
object when setting the Uri (e.g. 
http://code.google.com/p/idoubs/source/browse/branches/2.0/common-ngn-stack/sip/
NgnSipSession.mm#112) instead of a String.

Original comment by boss...@yahoo.fr on 13 Dec 2011 at 4:49

GoogleCodeExporter commented 9 years ago
what is the solution for this problem? I did not understand from above answers. 
sorry 

Original comment by mr3li.al...@gmail.com on 10 Mar 2013 at 4:40