Open 3akev opened 2 months ago
Attention: Patch coverage is 22.22222%
with 21 lines
in your changes missing coverage. Please review.
Project coverage is 47.34%. Comparing base (
2815bad
) to head (ba30f2d
).
Files with missing lines | Patch % | Lines |
---|---|---|
lib/pages/editor/editor.dart | 23.52% | 13 Missing :warning: |
lib/components/canvas/canvas_gesture_detector.dart | 20.00% | 8 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This looks good from the code. What device/s have you tested with? iirc pressing the S-pen button while hovering made the stylus not work temporarily
This looks good from the code. What device/s have you tested with? iirc pressing the S-pen button while hovering made the stylus not work temporarily
I tested this on a Galaxy S6 Lite with the S-pen. Unfortunately I don't have access to another device with a stylus, so I can't test this further. It should work on other devices, though.
This PR adds handlers for hovering stylus events, which are used to switch to the eraser tool when the stylus button is pressed while hovering.
This replaces the old functionality where pressing the stylus button mid-stroke removes the stroke, making it more in-line with other note applications and (in my opinion) more user friendly.
Closes #859