saber-notes / saber

The cross-platform open-source app built for handwriting
https://saber.adil.hanney.org
GNU General Public License v3.0
1.94k stars 118 forks source link

Pen buttons on Android #859

Open xx1182 opened 11 months ago

xx1182 commented 11 months ago

Describe the bug

A button on the pen, it's usually for erasing, or whatever you set it.

To reproduce

  1. Open the app
  2. Start a new note or whiteboard
  3. Draw
  4. Press the button on the pen

Expected behavior

When you press the button, it should select the eraser or hilghliter tool; relase the button, and 6oure back to pen input.

Saber version

v0.14.11 Google Play (14110)

Device

Anything else?

Great app, but please record yourself drawing with a pencil on paper and add it as an additional option to hear the brushing. Otherwise, responsive, still great!

Iey4iej3 commented 11 months ago

SPen button should work to some extent, and now it is working as an eraser, although there are some minor issues: https://github.com/adil192/saber/issues/797#issuecomment-1636720025

xx1182 commented 11 months ago

SPen button should work to some extent, and now it is working as an eraser, although there are some minor issues: #797 (comment)

Mine doesn't, probably because isn't the "powered one"(the pro version which uses Bluetooth or the ones inside the Note series), it's the fold one. It works to some extent like you said, it gets recognised as a pen so don't have to use the "draw with finger", but the physical button doesn't work, nothing happens

ceskyDJ commented 11 months ago

Did you try to touch the screen by the pen, and while holding the pen on the screen tap the button on the pen? It's not good UX, but it should work (toggle eraser). Saber waits for better pen support by Flutter. For now, we need to wait, too, and hope the stylus support will come early.

xx1182 commented 11 months ago

No, did not try it and infact works as you say.

Is there any plan to support "pixel eraser", erases around a radius? Regards.

srghma commented 10 months ago

Did you try to touch the screen by the pen, and while holding the pen on the screen tap the button on the pen

Works

adil192 commented 10 months ago

Is there any plan to support "pixel eraser", erases around a radius? Regards.

It's not currently a high priority issue, see https://github.com/adil192/saber/issues/40.

djibux commented 9 months ago

Same issue as OP, with a Samsung Galaxy S6 lite. Pen is also not powered.

Did you try to touch the screen by the pen, and while holding the pen on the screen tap the button on the pen

Indeed that works: the pen needs to be touching the screen. Hovering is not enough.

Iey4iej3 commented 9 months ago

Indeed that works: the pen needs to be touching the screen. Hovering is not enough.

This is a (very old) bug of flutter: https://github.com/flutter/flutter/issues/42846

I guess that it might help if you react there.

shayan15sa commented 4 months ago

Hey guys wanted let you know erasing with spen button works on Android 14 I just uptaded my tab s6 lite to android 14 now.It didn't used to work when I was on Android 13 but now it works fine.

ceskyDJ commented 3 months ago

It looks working for me, too. It still has it's own troubles (isn't so responsive like erasing in e.g. Samsung Notes), but it's way better than it used to be.

Microwave-WYB commented 1 week ago

Hey guys wanted let you know erasing with spen button works on Android 14 I just uptaded my tab s6 lite to android 14 now.It didn't used to work when I was on Android 13 but now it works fine.

How did you managed to update Tab S6 Lite to Android 14? I don't even receive Android 14 update on my S7+

shayan15sa commented 1 week ago

Hey guys wanted let you know erasing with spen button works on Android 14 I just uptaded my tab s6 lite to android 14 now.It didn't used to work when I was on Android 13 but now it works fine.

How did you managed to update Tab S6 Lite to Android 14? I don't even receive Android 14 update on my S7+

Hi I have the newer model (tab s6 lite 2022). I think that's why. There are some unofficial ram too.