Code Review: 04.22.22. - Githubissues

sabetech / todo-list-webpack

This is a todo project that uses vanilla JavaScript with webpack and experiments with Jest as a unit testing framework

1 stars 0 forks source link

Code Review: 04.22.22. #10

Open virag-ky opened 2 years ago

virag-ky commented 2 years ago

HTML/CSS/JavaScript

the code in all the files are looking clean
the Readme file is descriptive enough

Suggestions:

it's a good practice to put the JavaScript files into a modules folder so that they can be in one place
you can use this method to deploy your webpack projects with Github pages: https://medium.com/@cassandra.torske/one-way-to-deploy-your-bundled-javascript-project-to-github-pages-9f9bb2a1aaa1

Anyway, you did good with this project, I liked how you implemented the testing. :+1: