search

sabitovvt / vscode-favorites-panel

VSCODE Extension favorites panel
GNU General Public License v3.0
10 stars 12 forks source link

add setting `favoritesPanel.workspaceCommands` #14

Closed GitMensch closed 1 year ago

GitMensch commented 1 year ago

I suggest to use the same separation as https://github.com/usernamehw/vscode-commands/ by splitting the setting configuration - favoritesPanel.commands would then only be working where it currently is defined - in user configuration - while then new favoritesPanel.workspaceCommands would only work when defined in workspace settings.

This would have the additional benefit that a "common" set can be configured in possibly shared workspace configurations (especially run commands that are workspace specific like tests, server start, ...) while users can keep there general settings (especially editor related) in the user configuration.

After getting used to this in the other extension and seeing that user + workspace settings are the way to go (also with the option of settings sync between devices) I'm closing #11 in favor of this.

sabitovvt commented 1 year ago

In version 1.2.0 Added setting favoritesPanel.commandsForWorkspace Added setting favoritesPanel.configPathForWorkspace