search

sablier-labs / docs

Documentation and guides for Sablier
https://docs.sablier.com
GNU General Public License v3.0
14 stars 7 forks source link

Add new stream types for dynamic #137

Closed andreivladbrg closed 2 months ago

andreivladbrg commented 3 months ago

Closes https://github.com/sablier-labs/docs/issues/110

@PaulRBerg I have not added explanations for the graphs yet, as I don't know what specific use cases you have in mind for them. Could you share your ideas here? After that, I'll include the explanations accordingly.

The shapes look like the images below:

images ![image](https://github.com/sablier-labs/docs/assets/99738872/c5d5e84d-a4b0-4ad7-ac03-75553fd68298) ![image](https://github.com/sablier-labs/docs/assets/99738872/e560a0a5-4e55-43e2-a34a-293360efc67a) ![image](https://github.com/sablier-labs/docs/assets/99738872/d8d65133-2471-4c79-9964-9b48b10db367)
andreivladbrg commented 2 months ago

@PaulRBerg just wanted to let you know that I've pushed a commit that includes the descriptions

@smol-ninja also tagging you for a review

andreivladbrg commented 2 months ago

Thanks for the quick review. I agree with your suggestions and have just pushed the changes you recommended.

Should we rename "model" to "shape"?

I personally like "model"

Also, not sure why the CI fails. Do you have any idea?

smol-ninja commented 2 months ago

It's failing because of this:

Screenshot 2024-04-17 at 18 50 27
PaulRBerg commented 2 months ago

Man that bug with the NFT Descriptor is so annoying. See https://github.com/sablier-labs/docs/issues/46. It keeps creeping up.

Thanks @andreivladbrg, for providing the descriptions. I made some edits now.

I agree with @smol-ninja that "shapes" is better than "model". The UI uses shape, so it would be more consistent to use the same terminology in the docs.

PaulRBerg commented 2 months ago

Turns out the problem wasn't the NFT descriptor casing. It was Bun and a missing dev dependency (react-loadable). See this:

https://discord.com/channels/398180168688074762/867060369087922187/1191397897598672986

The build works now in CI.

andreivladbrg commented 2 months ago

Thanks for the CI fix, merging now