Closed ryabykhms closed 2 months ago
Thank you so much for the PR and for fixing the hyperlink issue @ryabykhms. This looks good to me 🚀. There are a few points that I would like to share with you:
The contract name in LockupStreamCreator.t.sol should be LockupStreamCreatorTest
. Currently, it is LockupLinearStreamCreatorTest
. Would you also like to create a PR in examples repo to fix that?
In the message after running forge test
, the following should be replaced
Running 1 test for test/StreamCreator.t.sol:StreamCreatorTest
[PASS] test_CreateStream() (gas: { gasValue })
Test result: ok. 1 passed; 0 failed; finished in { time }
by
Ran 2 tests for v2/core/LockupStreamCreator.t.sol:LockupStreamCreatorTest
[PASS] test_LockupDynamicStreamCreator() (gas: 273719)
[PASS] test_LockupLinearStreamCreator() (gas: 186388)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 6.34s (5.80s CPU time)
to make it look more realistic. Would you also like to include this in the PR?
Thank you for your comment @smol-ninja. I fixed that here: https://github.com/sablier-labs/examples/pull/31
In the PR https://github.com/sablier-labs/examples/pull/20, the test referenced in the documentation was removed and a new one was created.