sablier-labs / docs

Documentation and guides for Sablier
https://docs.sablier.com
GNU General Public License v3.0
14 stars 7 forks source link

fix: invalid link for stream creator test #147

Closed ryabykhms closed 2 months ago

ryabykhms commented 2 months ago

In the PR https://github.com/sablier-labs/examples/pull/20, the test referenced in the documentation was removed and a new one was created.

smol-ninja commented 2 months ago

Thank you so much for the PR and for fixing the hyperlink issue @ryabykhms. This looks good to me 🚀. There are a few points that I would like to share with you:

by

Ran 2 tests for v2/core/LockupStreamCreator.t.sol:LockupStreamCreatorTest
[PASS] test_LockupDynamicStreamCreator() (gas: 273719)
[PASS] test_LockupLinearStreamCreator() (gas: 186388)
Suite result: ok. 2 passed; 0 failed; 0 skipped; finished in 6.34s (5.80s CPU time)

to make it look more realistic. Would you also like to include this in the PR?

ryabykhms commented 2 months ago

Thank you for your comment @smol-ninja. I fixed that here: https://github.com/sablier-labs/examples/pull/31