Document footguns - Githubissues

sablier-labs / docs

Documentation and guides for Sablier

https://docs.sablier.com

GNU General Public License v3.0

16 stars 7 forks source link

Closed PaulRBerg closed 1 year ago

PaulRBerg commented 1 year ago

[x] Integrating contracts that accept NFT deposits need to account for potential withdrawals by the sender (ref https://github.com/cantinasec/review-sablier/issues/22)
[x] Recommend using withdrawMaxAndTransfer over transferFrom in this guide (ref https://github.com/sablier-labs/v2-interfaces/issues/450)

PaulRBerg commented 1 year ago

We ended up implementing a withdrawMaxAndTransfer function to address this issue with transferFrom:

The docs should recommend using withdrawMaxAndTransfer over transferFrom.