search

sablier-labs / flow

🍃 Smart contracts of the Sablier Flow protocol.
Other
8 stars 0 forks source link

Address feedback left on #155 #162

Closed andreivladbrg closed 4 months ago

andreivladbrg commented 4 months ago

Addresses my feedback left on https://github.com/sablier-labs/flow/pull/155 and more

Changes

test: add one more createAsset function test: add a new create stream function in Integration_Test test: use bound over assume for decimals and rps test: add createStreamWithNewAsset in Fixtures contract test: group constants to increase readability test: rename function in utils to boundTransferAmount

andreivladbrg commented 4 months ago

@smol-ninja forced push the commit, lmk if it looks good

andreivladbrg commented 4 months ago

@smol-ninja should we use bound for streamId in deposit as well?

streamId = _bound(streamId, 1, flow.nextStreamId() * 2);
smol-ninja commented 4 months ago

should we use bound for streamId in deposit as well?

Doesn't matter. It would only reject 0 input. All others would go through because of if else.

andreivladbrg commented 4 months ago

great, i think i've addressed everything, lmk if we can merge this