Spent my weekend in understanding each line of this PR. I think a few checks are redundant and there were some changes in the natspecs so I created this feedback PR to address my suggestions. It was easier that way then commenting in this PR.
Feel free to comment in this PR if you disagree with any changes.
Some changes:
In Base.t.sol, I've combined create and label assets in one function: createAndLabelAssets
Removed boundAddress and replaced its usage with makeAddr(vm.toString(abi.encodePacked(params.sender, i))); which is more bespoke
Some Natspec changes to make the descriptions more clear
Allow sender same as recipientincheckUsers`
Refactoring variable and function names
Remove seed variables. And use less number of variables.
Spent my weekend in understanding each line of this PR. I think a few checks are redundant and there were some changes in the natspecs so I created this feedback PR to address my suggestions. It was easier that way then commenting in this PR.
Feel free to comment in this PR if you disagree with any changes.
Some changes:
Base.t.sol, I've combined create and label assets in one function:createAndLabelAssetsboundAddressand replaced its usage withmakeAddr(vm.toString(abi.encodePacked(params.sender, i)));which is more bespokesendersame as recipientincheckUsers`