search

sablier-labs / flow

🍃 Smart contracts of the Sablier Flow protocol.
Other
8 stars 0 forks source link

Turn Bulloak CI workflow into a reusable GitHub Action #192

Closed PaulRBerg closed 2 months ago

PaulRBerg commented 2 months ago

We may want to use the Bulloak CI workflow in other Sablier repositories, so we should turn into a reusable GitHub Action published in the GitHub marketplace.

By building this, we would also do Alex a solid. And the open-source community may find it useful, too.

Similar to https://github.com/foundry-rs/foundry-toolchain.

smol-ninja commented 2 months ago

Sounds good. I also had a chat with Alex on this when I was writing the Bulloak CI. So, I'd explore it.

smol-ninja commented 2 months ago

I've published the GitHub action for Bulloak verifier.

Repo: https://github.com/smol-ninja/bulloak-verifier Marketplace: https://github.com/marketplace/actions/bulloak-toolchain

Question: Currently the repo is on my own GitHub profile. Should I transfer the ownership to Sablier org (MIT License grants copyright to Sablier Labs Ltd) or should I transfer the ownership to Alex since he is the one maintaining the Bulloak repo?

PaulRBerg commented 2 months ago

That's amazing, Shub!

Feel free to keep ownership of the Action. Maybe you can add me, Andrei, and Alex as contributors.

PaulRBerg commented 2 months ago

This is so cool it deserves a tweet.

smol-ninja commented 2 months ago

Thank you.

Maybe you can add me, Andrei, and Alex as contributors

Sure. I will do it and post a tweet too.