Closed PaulRBerg closed 2 months ago
As a personal heuristic, I always try to use short names when naming variables. However, in this case, I think “normalize” and “denormalize” are more precise than “scaled” and “raw,” tho I still like the latter two.
So, for me, both options work, and you can decide which one to use.
We can close this issue as well.
Savage.
I've swung back and forth between 'normalized' and 'scaled' for a while.
Now, I am in favor of refactoring
normalized
toscaled
, anddenormalized
toraw
because it's shorter, and I think it's a better fit for purpose.The following change list applies to the terminology implemented in #205:
normalized
prefix toscaled
raw
prefix to refactor because all non-prefixed amounts are assumed to be raw anyway, e.g.refundAmount
Helpers.denormalizeAmount
togetRawAmount
Helpers.normalizeAmount
togetScaledAmount
Alternatively, we could say
descaled
instead ofraw
, anddescaleAmount
instead ofgetRawAmount
.LMK what you think @sablier-labs/solidity.