sablier-labs / flow

🍃 Smart contracts of the Sablier Flow protocol.
Other
8 stars 0 forks source link

Refactor "normalized" to "scaled" and "denormalize" to "raw" #210

Closed PaulRBerg closed 2 months ago

PaulRBerg commented 2 months ago

I've swung back and forth between 'normalized' and 'scaled' for a while.

Now, I am in favor of refactoring normalized to scaled, and denormalized to raw because it's shorter, and I think it's a better fit for purpose.

The following change list applies to the terminology implemented in #205:

Alternatively, we could say descaled instead of raw, and descaleAmount instead of getRawAmount.

LMK what you think @sablier-labs/solidity.

andreivladbrg commented 2 months ago

As a personal heuristic, I always try to use short names when naming variables. However, in this case, I think “normalize” and “denormalize” are more precise than “scaled” and “raw,” tho I still like the latter two.

So, for me, both options work, and you can decide which one to use.

smol-ninja commented 2 months ago

We can close this issue as well.

PaulRBerg commented 2 months ago

Savage.